feat: add reanalyze dead code analysis to all ReScript libs#810
Open
BlueHotDog wants to merge 4 commits intomainfrom
Open
feat: add reanalyze dead code analysis to all ReScript libs#810BlueHotDog wants to merge 4 commits intomainfrom
BlueHotDog wants to merge 4 commits intomainfrom
Conversation
When a cancelled turn is retried, RetryTurn cleared turnError but left isAgentRunning as false. The streaming guard (line 852) then silently dropped all incoming StreamingStarted/TextDelta/ToolCall events from the restarted execution, causing the server to work but no messages to appear on the client. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #807
Summary
reanalyzeDCE config to all 11 ReScript libs that were missing it (bindings,experimental-rescript-webapi,frontman-astro,frontman-astro-browser,frontman-client,frontman-core,frontman-nextjs,frontman-protocol,frontman-vite,logs,react-statestore)dead-code-libsmatrix CI job covering all 11 libs (mirrors the existingdead-code-clientjob, usesfail-fast: falseso all legs run independently)lefthook.yml— all 12 libs (includingclient) are checked before every pushAll libs currently report 0 dead code issues.
Test Plan
dead-code-libspass in CIdead-code-clientjob still passesfrontman-client,frontman-core,frontman-nextjs,react-statestore,logs)🤖 Generated with Claude Code